Please help clarify :Add cluster (de)activation events IGNITE-8376

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

Please help clarify :Add cluster (de)activation events IGNITE-8376

kcheng.mvp
This post was updated on .
Dear igniters,I am going to pick up
https://issues.apache.org/jira/browse/IGNITE-8376, and did some research
based on the comments.based on my understanding, if we want to know this
action is triggered by which way(rest, mbean, auto or visocmd)  then we need
to change the core method's signature.I am not sure my understanding is
correct or not. Can anybody help to clarify this? Thank you very much.By the
way, I commented this in jira as well.Thanks youkcvmp



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

dsetrakyan
Do we really not have events in Ignite for cluster activation?

Alexey Goncharuk, can you please comment?

D.

On Mon, Jul 2, 2018 at 1:34 AM, kcheng.mvp <[hidden email]> wrote:

> Dear igniters,I am going to pick up
> https://issues.apache.org/jira/browse/IGNITE-8376, and did some research
> based on the comments.based on my understanding, if we want to know this
> action is triggered by which way(rest, mbean, auto or visocmd)  then we
> need
> to change the core method's signature.I am not sure my understanding is
> correct or not. Can anybody help to clarify this? Thank you very much.By
> the
> way, I commented this in jira as well.Thanks youkcvmp
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

kcheng.mvp
I checked the code again, seems there is no such event.


Thanks,
Ken Cheng


On Tue, Jul 3, 2018 at 7:41 AM Dmitriy Setrakyan <[hidden email]>
wrote:

> Do we really not have events in Ignite for cluster activation?
>
> Alexey Goncharuk, can you please comment?
>
> D.
>
> On Mon, Jul 2, 2018 at 1:34 AM, kcheng.mvp <[hidden email]> wrote:
>
> > Dear igniters,I am going to pick up
> > https://issues.apache.org/jira/browse/IGNITE-8376, and did some research
> > based on the comments.based on my understanding, if we want to know this
> > action is triggered by which way(rest, mbean, auto or visocmd)  then we
> > need
> > to change the core method's signature.I am not sure my understanding is
> > correct or not. Can anybody help to clarify this? Thank you very much.By
> > the
> > way, I commented this in jira as well.Thanks youkcvmp
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

kcheng.mvp
In reply to this post by dsetrakyan
Hi dsetrakyan,

I checked the source again and found there is a customized Event sent out
with below code

org.apache.ignite.internal.processors.cluster.GridClusterSta
teProcessor#changeGlobalState0

I am not sure what you are referencing is this part? or still we need a
dedicated event for cluster status changes?

Thank you very much,
kcmvp

==============================
        ChangeGlobalStateMessage msg = new ChangeGlobalStateMessage(start
edFut.requestId,
            ctx.localNodeId(),
            storedCfgs,
            activate,
            blt,
            forceChangeBaselineTopology,
            System.currentTimeMillis());

        try {
            if (log.isInfoEnabled())
                U.log(log, "Sending " + prettyStr(activate) + " request
with BaselineTopology " + blt);

            ctx.discovery().sendCustomEvent(msg);
====================================


Thanks,
Ken Cheng


On Tue, Jul 3, 2018 at 7:41 AM Dmitriy Setrakyan <[hidden email]>
wrote:

> Do we really not have events in Ignite for cluster activation?
>
> Alexey Goncharuk, can you please comment?
>
> D.
>
> On Mon, Jul 2, 2018 at 1:34 AM, kcheng.mvp <[hidden email]> wrote:
>
> > Dear igniters,I am going to pick up
> > https://issues.apache.org/jira/browse/IGNITE-8376, and did some research
> > based on the comments.based on my understanding, if we want to know this
> > action is triggered by which way(rest, mbean, auto or visocmd)  then we
> > need
> > to change the core method's signature.I am not sure my understanding is
> > correct or not. Can anybody help to clarify this? Thank you very much.By
> > the
> > way, I commented this in jira as well.Thanks youkcvmp
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

kcheng.mvp
In reply to this post by dsetrakyan
Hi dsetrakyan,

I checked the source again and found there is a customized Event sent out
with below code

org.apache.ignite.internal.processors.cluster.GridClusterSta
teProcessor#changeGlobalState0

I am not sure what you are referencing is this part? or still we need a
dedicated event for cluster status changes?

Thank you very much,
kcmvp

==============================
        ChangeGlobalStateMessage msg = new ChangeGlobalStateMessage(start
edFut.requestId,
            ctx.localNodeId(),
            storedCfgs,
            activate,
            blt,
            forceChangeBaselineTopology,
            System.currentTimeMillis());

        try {
            if (log.isInfoEnabled())
                U.log(log, "Sending " + prettyStr(activate) + " request
with BaselineTopology " + blt);

            ctx.discovery().sendCustomEvent(msg);
====================================
Thanks,
Ken Cheng


On Tue, Jul 3, 2018 at 7:41 AM Dmitriy Setrakyan <[hidden email]>
wrote:

> Do we really not have events in Ignite for cluster activation?
>
> Alexey Goncharuk, can you please comment?
>
> D.
>
> On Mon, Jul 2, 2018 at 1:34 AM, kcheng.mvp <[hidden email]> wrote:
>
> > Dear igniters,I am going to pick up
> > https://issues.apache.org/jira/browse/IGNITE-8376, and did some research
> > based on the comments.based on my understanding, if we want to know this
> > action is triggered by which way(rest, mbean, auto or visocmd)  then we
> > need
> > to change the core method's signature.I am not sure my understanding is
> > correct or not. Can anybody help to clarify this? Thank you very much.By
> > the
> > way, I commented this in jira as well.Thanks youkcvmp
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

ezhuravl
Guys,

Do we really need events for activation/deactivation? We already have a
ticket for implementation lifecycle events for it:
https://issues.apache.org/jira/browse/IGNITE-5427, won't it be enough?

Evgenii

2018-07-03 16:06 GMT+03:00 Ken Cheng <[hidden email]>:

> Hi dsetrakyan,
>
> I checked the source again and found there is a customized Event sent out
> with below code
>
> org.apache.ignite.internal.processors.cluster.GridClusterSta
> teProcessor#changeGlobalState0
>
> I am not sure what you are referencing is this part? or still we need a
> dedicated event for cluster status changes?
>
> Thank you very much,
> kcmvp
>
> ==============================
>         ChangeGlobalStateMessage msg = new ChangeGlobalStateMessage(start
> edFut.requestId,
>             ctx.localNodeId(),
>             storedCfgs,
>             activate,
>             blt,
>             forceChangeBaselineTopology,
>             System.currentTimeMillis());
>
>         try {
>             if (log.isInfoEnabled())
>                 U.log(log, "Sending " + prettyStr(activate) + " request
> with BaselineTopology " + blt);
>
>             ctx.discovery().sendCustomEvent(msg);
> ====================================
> Thanks,
> Ken Cheng
>
>
> On Tue, Jul 3, 2018 at 7:41 AM Dmitriy Setrakyan <[hidden email]>
> wrote:
>
> > Do we really not have events in Ignite for cluster activation?
> >
> > Alexey Goncharuk, can you please comment?
> >
> > D.
> >
> > On Mon, Jul 2, 2018 at 1:34 AM, kcheng.mvp <[hidden email]> wrote:
> >
> > > Dear igniters,I am going to pick up
> > > https://issues.apache.org/jira/browse/IGNITE-8376, and did some
> research
> > > based on the comments.based on my understanding, if we want to know
> this
> > > action is triggered by which way(rest, mbean, auto or visocmd)  then we
> > > need
> > > to change the core method's signature.I am not sure my understanding is
> > > correct or not. Can anybody help to clarify this? Thank you very
> much.By
> > > the
> > > way, I commented this in jira as well.Thanks youkcvmp
> > >
> > >
> > >
> > > --
> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

dsetrakyan
On Thu, Jul 5, 2018 at 1:55 AM, Evgenii Zhuravlev <[hidden email]>
wrote:

> Guys,
>
> Do we really need events for activation/deactivation? We already have a
> ticket for implementation lifecycle events for it:
> https://issues.apache.org/jira/browse/IGNITE-5427, won't it be enough?
>

Hm... I think these two tickets are duplicates of one another, no?
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

ezhuravl
I've linked them as duplicates, however, one ticket suggests to add
Lifecycle events, while another is for adding our simple events
from EventType

Evgenii

2018-07-06 1:10 GMT+03:00 Dmitriy Setrakyan <[hidden email]>:

> On Thu, Jul 5, 2018 at 1:55 AM, Evgenii Zhuravlev <
> [hidden email]>
> wrote:
>
> > Guys,
> >
> > Do we really need events for activation/deactivation? We already have a
> > ticket for implementation lifecycle events for it:
> > https://issues.apache.org/jira/browse/IGNITE-5427, won't it be enough?
> >
>
> Hm... I think these two tickets are duplicates of one another, no?
>
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

dsetrakyan
What is the difference between a lifecycle even and regular events?

On Fri, Jul 6, 2018 at 12:25 AM, Evgenii Zhuravlev <[hidden email]
> wrote:

> I've linked them as duplicates, however, one ticket suggests to add
> Lifecycle events, while another is for adding our simple events
> from EventType
>
> Evgenii
>
> 2018-07-06 1:10 GMT+03:00 Dmitriy Setrakyan <[hidden email]>:
>
> > On Thu, Jul 5, 2018 at 1:55 AM, Evgenii Zhuravlev <
> > [hidden email]>
> > wrote:
> >
> > > Guys,
> > >
> > > Do we really need events for activation/deactivation? We already have a
> > > ticket for implementation lifecycle events for it:
> > > https://issues.apache.org/jira/browse/IGNITE-5427, won't it be enough?
> > >
> >
> > Hm... I think these two tickets are duplicates of one another, no?
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

Alexey Kuznetsov
Igniters,

Could we also have Enum  like this: ClusterState {ACTIVE, INACTIVE,
ACTIVATING, DEACTIVATING} ?
This will be very useful for external tools such as Web Console.
Right now there no way to detect if cluster in progress of activation or
deactivation.

--
Alexey Kuznetsov
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

yzhdanov
In reply to this post by dsetrakyan
> What is the difference between a lifecycle even and regular events?

Lifecycle events should be used when there is no opportunity for Ignite to
fire regular event, e.g. node stops or is not started yet. Please see
https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/lifecycle/LifecycleEventType.html

--Yakov
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

kcheng.mvp
I left a comments on jira. can you  clarify it,please?



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

dsetrakyan
In reply to this post by yzhdanov
On Mon, Jul 9, 2018 at 1:32 PM, Yakov Zhdanov <[hidden email]> wrote:

> > What is the difference between a lifecycle even and regular events?
>
> Lifecycle events should be used when there is no opportunity for Ignite to
> fire regular event, e.g. node stops or is not started yet. Please see
> https://ignite.apache.org/releases/latest/javadoc/org/
> apache/ignite/lifecycle/LifecycleEventType.html


In this case I do not understand why activation should be a lifecycle
event. During activation Ignite has already started and events can be
reported using normal event notification support in Ignite, no?

D.
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

yzhdanov
Its counter event on_after_deactivated cannot be fired through event
notification support. Therefore, it is better to gather such events in
LifeCycleEventType.

--Yakov
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

dsetrakyan
On Thu, Jul 12, 2018 at 3:08 PM, Yakov Zhdanov <[hidden email]> wrote:

> Its counter event on_after_deactivated cannot be fired through event
> notification support. Therefore, it is better to gather such events in
> LifeCycleEventType.
>

Why not? After deactivation the node should still be usable and should be
able to fire events. Can you explain?
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

yzhdanov
If events are working when grid is not active and adding/removing listeners
is also possible then I agree/

--Yakov
Reply | Threaded
Open this post in threaded view
|

Re: Add cluster (de)activation events IGNITE-8376

dsetrakyan
On Thu, Jul 12, 2018 at 3:22 PM, Yakov Zhdanov <[hidden email]> wrote:

> If events are working when grid is not active and adding/removing listeners
> is also possible then I agree/
>

The events should be working. The cluster is not active, but the node is
started and should be able to fire events.

AG, can you comment?