Replace Cron4J with Quartz for ignite-schedule module.

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Replace Cron4J with Quartz for ignite-schedule module.

Alexey Kuznetsov
Hi!

1) Cron4J is very old:
  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
  Latest Quarz 2.3.0 released: *20-Apr-2017*

2) Not very friendly license:
  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
  Quartz is freely usable, licensed under the *Apache 2.0* license.

So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
 from lgpl profile to main distribution.

Any objections?

If no, I will create JIRA issue and implement this change.

--
Alexey Kuznetsov
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

dsetrakyan
Alexey,

Can you remind what we use the schedule module in Ignite for?

D.

On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <[hidden email]>
wrote:

> Hi!
>
> 1) Cron4J is very old:
>   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>   Latest Quarz 2.3.0 released: *20-Apr-2017*
>
> 2) Not very friendly license:
>   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>   Quartz is freely usable, licensed under the *Apache 2.0* license.
>
> So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
>  from lgpl profile to main distribution.
>
> Any objections?
>
> If no, I will create JIRA issue and implement this change.
>
> --
> Alexey Kuznetsov
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Alexey Kuznetsov
Dima,

IgniteScheduler provides functionality for scheduling jobs locally using
UNIX cron-based syntax. Instance of GridScheduler is obtained from grid as
follows:
   IgniteScheduler s = Ignition.ignite().scheduler();

Scheduler supports standard UNIX cron format with optional prefix of {n1,
n2}, where n1 is delay of scheduling in seconds and n2 is the number of
execution.
Both parameters are optional. Here's an example of scheduling a closure
that broadcasts a message to all nodes five times, once every minute, with
initial delay of two seconds:
   Ignition.ignite().scheduler().scheduleLocal(
       SchedulerFuture<?> = Ignition.ignite().scheduler().scheduleLocal(new
Callable<Object>() {
           @Override public Object call() throws IgniteCheckedException {
               ......
           }
       }, "{2, 5} * * * * *" // 2 seconds delay with 5 executions only.
   );

On Wed, Jun 21, 2017 at 1:31 PM, Dmitriy Setrakyan <[hidden email]>
wrote:

> Alexey,
>
> Can you remind what we use the schedule module in Ignite for?
>
> D.
>
> On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <[hidden email]>
> wrote:
>
> > Hi!
> >
> > 1) Cron4J is very old:
> >   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> >   Latest Quarz 2.3.0 released: *20-Apr-2017*
> >
> > 2) Not very friendly license:
> >   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> >   Quartz is freely usable, licensed under the *Apache 2.0* license.
> >
> > So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> module
> >  from lgpl profile to main distribution.
> >
> > Any objections?
> >
> > If no, I will create JIRA issue and implement this change.
> >
> > --
> > Alexey Kuznetsov
> >
>



--
Alexey Kuznetsov
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

dsetrakyan
Thanks! Please file a ticket. Do you have an idea on the amount of work
this would require?

On Wed, Jun 21, 2017 at 8:39 AM, Alexey Kuznetsov <[hidden email]>
wrote:

> Dima,
>
> IgniteScheduler provides functionality for scheduling jobs locally using
> UNIX cron-based syntax. Instance of GridScheduler is obtained from grid as
> follows:
>    IgniteScheduler s = Ignition.ignite().scheduler();
>
> Scheduler supports standard UNIX cron format with optional prefix of {n1,
> n2}, where n1 is delay of scheduling in seconds and n2 is the number of
> execution.
> Both parameters are optional. Here's an example of scheduling a closure
> that broadcasts a message to all nodes five times, once every minute, with
> initial delay of two seconds:
>    Ignition.ignite().scheduler().scheduleLocal(
>        SchedulerFuture<?> = Ignition.ignite().scheduler().
> scheduleLocal(new
> Callable<Object>() {
>            @Override public Object call() throws IgniteCheckedException {
>                ......
>            }
>        }, "{2, 5} * * * * *" // 2 seconds delay with 5 executions only.
>    );
>
> On Wed, Jun 21, 2017 at 1:31 PM, Dmitriy Setrakyan <[hidden email]>
> wrote:
>
> > Alexey,
> >
> > Can you remind what we use the schedule module in Ignite for?
> >
> > D.
> >
> > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <[hidden email]
> >
> > wrote:
> >
> > > Hi!
> > >
> > > 1) Cron4J is very old:
> > >   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> > >   Latest Quarz 2.3.0 released: *20-Apr-2017*
> > >
> > > 2) Not very friendly license:
> > >   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> > >   Quartz is freely usable, licensed under the *Apache 2.0* license.
> > >
> > > So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> > module
> > >  from lgpl profile to main distribution.
> > >
> > > Any objections?
> > >
> > > If no, I will create JIRA issue and implement this change.
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Alexey Kuznetsov
Done,

https://issues.apache.org/jira/browse/IGNITE-5565

I think it could take a couple of days in background mode.

On Wed, Jun 21, 2017 at 1:40 PM, Dmitriy Setrakyan <[hidden email]>
wrote:

> Thanks! Please file a ticket. Do you have an idea on the amount of work
> this would require?
>
> On Wed, Jun 21, 2017 at 8:39 AM, Alexey Kuznetsov <[hidden email]>
> wrote:
>
> > Dima,
> >
> > IgniteScheduler provides functionality for scheduling jobs locally using
> > UNIX cron-based syntax. Instance of GridScheduler is obtained from grid
> as
> > follows:
> >    IgniteScheduler s = Ignition.ignite().scheduler();
> >
> > Scheduler supports standard UNIX cron format with optional prefix of {n1,
> > n2}, where n1 is delay of scheduling in seconds and n2 is the number of
> > execution.
> > Both parameters are optional. Here's an example of scheduling a closure
> > that broadcasts a message to all nodes five times, once every minute,
> with
> > initial delay of two seconds:
> >    Ignition.ignite().scheduler().scheduleLocal(
> >        SchedulerFuture<?> = Ignition.ignite().scheduler().
> > scheduleLocal(new
> > Callable<Object>() {
> >            @Override public Object call() throws IgniteCheckedException {
> >                ......
> >            }
> >        }, "{2, 5} * * * * *" // 2 seconds delay with 5 executions only.
> >    );
> >
> > On Wed, Jun 21, 2017 at 1:31 PM, Dmitriy Setrakyan <
> [hidden email]>
> > wrote:
> >
> > > Alexey,
> > >
> > > Can you remind what we use the schedule module in Ignite for?
> > >
> > > D.
> > >
> > > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <
> [hidden email]
> > >
> > > wrote:
> > >
> > > > Hi!
> > > >
> > > > 1) Cron4J is very old:
> > > >   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> > > >   Latest Quarz 2.3.0 released: *20-Apr-2017*
> > > >
> > > > 2) Not very friendly license:
> > > >   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> > > >   Quartz is freely usable, licensed under the *Apache 2.0* license.
> > > >
> > > > So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> > > module
> > > >  from lgpl profile to main distribution.
> > > >
> > > > Any objections?
> > > >
> > > > If no, I will create JIRA issue and implement this change.
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
>



--
Alexey Kuznetsov
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

dsetrakyan
Probably a good task for a newbie.

⁣D.​

On Jun 21, 2017, 9:41 AM, at 9:41 AM, Alexey Kuznetsov <[hidden email]> wrote:

>Done,
>
>https://issues.apache.org/jira/browse/IGNITE-5565
>
>I think it could take a couple of days in background mode.
>
>On Wed, Jun 21, 2017 at 1:40 PM, Dmitriy Setrakyan
><[hidden email]>
>wrote:
>
>> Thanks! Please file a ticket. Do you have an idea on the amount of
>work
>> this would require?
>>
>> On Wed, Jun 21, 2017 at 8:39 AM, Alexey Kuznetsov
><[hidden email]>
>> wrote:
>>
>> > Dima,
>> >
>> > IgniteScheduler provides functionality for scheduling jobs locally
>using
>> > UNIX cron-based syntax. Instance of GridScheduler is obtained from
>grid
>> as
>> > follows:
>> >    IgniteScheduler s = Ignition.ignite().scheduler();
>> >
>> > Scheduler supports standard UNIX cron format with optional prefix
>of {n1,
>> > n2}, where n1 is delay of scheduling in seconds and n2 is the
>number of
>> > execution.
>> > Both parameters are optional. Here's an example of scheduling a
>closure
>> > that broadcasts a message to all nodes five times, once every
>minute,
>> with
>> > initial delay of two seconds:
>> >    Ignition.ignite().scheduler().scheduleLocal(
>> >        SchedulerFuture<?> = Ignition.ignite().scheduler().
>> > scheduleLocal(new
>> > Callable<Object>() {
>> >            @Override public Object call() throws
>IgniteCheckedException {
>> >                ......
>> >            }
>> >        }, "{2, 5} * * * * *" // 2 seconds delay with 5 executions
>only.
>> >    );
>> >
>> > On Wed, Jun 21, 2017 at 1:31 PM, Dmitriy Setrakyan <
>> [hidden email]>
>> > wrote:
>> >
>> > > Alexey,
>> > >
>> > > Can you remind what we use the schedule module in Ignite for?
>> > >
>> > > D.
>> > >
>> > > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <
>> [hidden email]
>> > >
>> > > wrote:
>> > >
>> > > > Hi!
>> > > >
>> > > > 1) Cron4J is very old:
>> > > >   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>> > > >   Latest Quarz 2.3.0 released: *20-Apr-2017*
>> > > >
>> > > > 2) Not very friendly license:
>> > > >   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>> > > >   Quartz is freely usable, licensed under the *Apache 2.0*
>license.
>> > > >
>> > > > So, if we replace Cron4J  with Quartz we can move
>*ignite-schedule*
>> > > module
>> > > >  from lgpl profile to main distribution.
>> > > >
>> > > > Any objections?
>> > > >
>> > > > If no, I will create JIRA issue and implement this change.
>> > > >
>> > > > --
>> > > > Alexey Kuznetsov
>> > > >
>> > >
>> >
>> >
>> >
>> > --
>> > Alexey Kuznetsov
>> >
>>
>
>
>
>--
>Alexey Kuznetsov
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

李玉珏
In reply to this post by Alexey Kuznetsov
Hi,


There is also an alternative that the community can consider using the scheduling functionality in the spring-context module, for the following reasons:
1.quartz is a very heavy framework, and most functions we don't need;
2., we already have spring dependencies in our project without introducing new dependencies;
3.spring is also Apache 2.0 license;
4.spring's scheduler supports standard CRON, and cron4j does not support standard CRON;
5.spring's code quality is very good, maintainability is good, and the quality of quartz code is not very good.
On 06/21/2017 13:26,Alexey Kuznetsov<[hidden email]> wrote:
Hi!

1) Cron4J is very old:
  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
  Latest Quarz 2.3.0 released: *20-Apr-2017*

2) Not very friendly license:
  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
  Quartz is freely usable, licensed under the *Apache 2.0* license.

So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
 from lgpl profile to main distribution.

Any objections?

If no, I will create JIRA issue and implement this change.

--
Alexey Kuznetsov
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Alexey Kuznetsov-2
Hi!

Good point, I will take a look.

On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏 <[hidden email]> wrote:

> Hi,
>
>
> There is also an alternative that the community can consider using the
> scheduling functionality in the spring-context module, for the following
> reasons:
> 1.quartz is a very heavy framework, and most functions we don't need;
> 2., we already have spring dependencies in our project without introducing
> new dependencies;
> 3.spring is also Apache 2.0 license;
> 4.spring's scheduler supports standard CRON, and cron4j does not support
> standard CRON;
> 5.spring's code quality is very good, maintainability is good, and the
> quality of quartz code is not very good.
> On 06/21/2017 13:26,Alexey Kuznetsov<[hidden email]> wrote:
> Hi!
>
> 1) Cron4J is very old:
>   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>   Latest Quarz 2.3.0 released: *20-Apr-2017*
>
> 2) Not very friendly license:
>   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>   Quartz is freely usable, licensed under the *Apache 2.0* license.
>
> So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
>  from lgpl profile to main distribution.
>
> Any objections?
>
> If no, I will create JIRA issue and implement this change.
>
> --
> Alexey Kuznetsov
>



--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Michael André Pearce
If taking the quartz route, it be great if ignite could expose a distributed ignite job store, so you could setup and use quartz in a distributed way, in a similar way to terracotta or hazelcasts quartz jobstores.


Sent from my iPhone

> On 21 Jun 2017, at 15:43, Alexey Kuznetsov <[hidden email]> wrote:
>
> Hi!
>
> Good point, I will take a look.
>
>> On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏 <[hidden email]> wrote:
>>
>> Hi,
>>
>>
>> There is also an alternative that the community can consider using the
>> scheduling functionality in the spring-context module, for the following
>> reasons:
>> 1.quartz is a very heavy framework, and most functions we don't need;
>> 2., we already have spring dependencies in our project without introducing
>> new dependencies;
>> 3.spring is also Apache 2.0 license;
>> 4.spring's scheduler supports standard CRON, and cron4j does not support
>> standard CRON;
>> 5.spring's code quality is very good, maintainability is good, and the
>> quality of quartz code is not very good.
>> On 06/21/2017 13:26,Alexey Kuznetsov<[hidden email]> wrote:
>> Hi!
>>
>> 1) Cron4J is very old:
>>  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>>  Latest Quarz 2.3.0 released: *20-Apr-2017*
>>
>> 2) Not very friendly license:
>>  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>>  Quartz is freely usable, licensed under the *Apache 2.0* license.
>>
>> So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
>> from lgpl profile to main distribution.
>>
>> Any objections?
>>
>> If no, I will create JIRA issue and implement this change.
>>
>> --
>> Alexey Kuznetsov
>>
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Valentin Kulichenko
I think Michael brought up a very good point. Current ignite-scheduler
module schedules jobs only locally which is not very useful in distributed
system. I don't think I've ever seen it used and I don't think it makes
sense to spend time on it if we just replace one dependency with another.
However, if we switch to Quartz in order to enhance functionality and
introduce distributed scheduling - that can add value.

-Val

On Wed, Jun 21, 2017 at 3:21 PM, Michael André Pearce <
[hidden email]> wrote:

> If taking the quartz route, it be great if ignite could expose a
> distributed ignite job store, so you could setup and use quartz in a
> distributed way, in a similar way to terracotta or hazelcasts quartz
> jobstores.
>
>
> Sent from my iPhone
>
> > On 21 Jun 2017, at 15:43, Alexey Kuznetsov <[hidden email]>
> wrote:
> >
> > Hi!
> >
> > Good point, I will take a look.
> >
> >> On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏 <[hidden email]> wrote:
> >>
> >> Hi,
> >>
> >>
> >> There is also an alternative that the community can consider using the
> >> scheduling functionality in the spring-context module, for the following
> >> reasons:
> >> 1.quartz is a very heavy framework, and most functions we don't need;
> >> 2., we already have spring dependencies in our project without
> introducing
> >> new dependencies;
> >> 3.spring is also Apache 2.0 license;
> >> 4.spring's scheduler supports standard CRON, and cron4j does not support
> >> standard CRON;
> >> 5.spring's code quality is very good, maintainability is good, and the
> >> quality of quartz code is not very good.
> >> On 06/21/2017 13:26,Alexey Kuznetsov<[hidden email]> wrote:
> >> Hi!
> >>
> >> 1) Cron4J is very old:
> >>  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> >>  Latest Quarz 2.3.0 released: *20-Apr-2017*
> >>
> >> 2) Not very friendly license:
> >>  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> >>  Quartz is freely usable, licensed under the *Apache 2.0* license.
> >>
> >> So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> module
> >> from lgpl profile to main distribution.
> >>
> >> Any objections?
> >>
> >> If no, I will create JIRA issue and implement this change.
> >>
> >> --
> >> Alexey Kuznetsov
> >>
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Alexey Kuznetsov-2
Val and Michael ,

Very good point!

Any idea how it could be implemented?

Actually I need distributed scheduling.


On Thu, Jun 22, 2017 at 5:37 AM, Valentin Kulichenko <
[hidden email]> wrote:

> I think Michael brought up a very good point. Current ignite-scheduler
> module schedules jobs only locally which is not very useful in distributed
> system. I don't think I've ever seen it used and I don't think it makes
> sense to spend time on it if we just replace one dependency with another.
> However, if we switch to Quartz in order to enhance functionality and
> introduce distributed scheduling - that can add value.
>
> -Val
>
> On Wed, Jun 21, 2017 at 3:21 PM, Michael André Pearce <
> [hidden email]> wrote:
>
> > If taking the quartz route, it be great if ignite could expose a
> > distributed ignite job store, so you could setup and use quartz in a
> > distributed way, in a similar way to terracotta or hazelcasts quartz
> > jobstores.
> >
> >
> > Sent from my iPhone
> >
> > > On 21 Jun 2017, at 15:43, Alexey Kuznetsov <[hidden email]>
> > wrote:
> > >
> > > Hi!
> > >
> > > Good point, I will take a look.
> > >
> > >> On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏 <[hidden email]> wrote:
> > >>
> > >> Hi,
> > >>
> > >>
> > >> There is also an alternative that the community can consider using the
> > >> scheduling functionality in the spring-context module, for the
> following
> > >> reasons:
> > >> 1.quartz is a very heavy framework, and most functions we don't need;
> > >> 2., we already have spring dependencies in our project without
> > introducing
> > >> new dependencies;
> > >> 3.spring is also Apache 2.0 license;
> > >> 4.spring's scheduler supports standard CRON, and cron4j does not
> support
> > >> standard CRON;
> > >> 5.spring's code quality is very good, maintainability is good, and the
> > >> quality of quartz code is not very good.
> > >> On 06/21/2017 13:26,Alexey Kuznetsov<[hidden email]> wrote:
> > >> Hi!
> > >>
> > >> 1) Cron4J is very old:
> > >>  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> > >>  Latest Quarz 2.3.0 released: *20-Apr-2017*
> > >>
> > >> 2) Not very friendly license:
> > >>  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> > >>  Quartz is freely usable, licensed under the *Apache 2.0* license.
> > >>
> > >> So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> > module
> > >> from lgpl profile to main distribution.
> > >>
> > >> Any objections?
> > >>
> > >> If no, I will create JIRA issue and implement this change.
> > >>
> > >> --
> > >> Alexey Kuznetsov
> > >>
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> >
>



--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

yzhdanov
Guys, I remember we discussed this some time ago.

http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html

Denis, do you have any ticket or SoW?

--Yakov
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Denis Magda-2
Yakov,

No, the mentioned discussion didn’t turn into a JIRA ticket.

Alex K., please follow to some thoughts from there and wrap them up in a form of the ticket.


Denis

> On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <[hidden email]> wrote:
>
> Guys, I remember we discussed this some time ago.
>
> http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html
>
> Denis, do you have any ticket or SoW?
>
> --Yakov

Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Dmitriy Pavlov
Hi Igniters,

it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is still
in PA state. What are our next steps?

Who did review of this patch?

Sincerely,
Dmitriy Pavlov

ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:

> Yakov,
>
> No, the mentioned discussion didn’t turn into a JIRA ticket.
>
> Alex K., please follow to some thoughts from there and wrap them up in a
> form of the ticket.
>
> —
> Denis
>
> > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <[hidden email]> wrote:
> >
> > Guys, I remember we discussed this some time ago.
> >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html
> >
> > Denis, do you have any ticket or SoW?
> >
> > --Yakov
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

dsetrakyan
Dmitriy, who is a good candidate within the community to review this ticket?

On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <[hidden email]>
wrote:

> Hi Igniters,
>
> it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is still
> in PA state. What are our next steps?
>
> Who did review of this patch?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:
>
> > Yakov,
> >
> > No, the mentioned discussion didn’t turn into a JIRA ticket.
> >
> > Alex K., please follow to some thoughts from there and wrap them up in a
> > form of the ticket.
> >
> > —
> > Denis
> >
> > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <[hidden email]>
> wrote:
> > >
> > > Guys, I remember we discussed this some time ago.
> > >
> > >
> > http://apache-ignite-developers.2346864.n4.nabble.
> com/Tasks-Scheduling-and-Chaining-td14293.html
> > >
> > > Denis, do you have any ticket or SoW?
> > >
> > > --Yakov
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Dmitriy Pavlov
Hi Andrey,

Could you please pick up review?

Sincerely,
Dmitriy Pavlov

пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <[hidden email]>:

> Dmitriy, who is a good candidate within the community to review this
> ticket?
>
> On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <[hidden email]>
> wrote:
>
> > Hi Igniters,
> >
> > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is
> still
> > in PA state. What are our next steps?
> >
> > Who did review of this patch?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:
> >
> > > Yakov,
> > >
> > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > >
> > > Alex K., please follow to some thoughts from there and wrap them up in
> a
> > > form of the ticket.
> > >
> > > —
> > > Denis
> > >
> > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <[hidden email]>
> > wrote:
> > > >
> > > > Guys, I remember we discussed this some time ago.
> > > >
> > > >
> > > http://apache-ignite-developers.2346864.n4.nabble.
> > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > >
> > > > Denis, do you have any ticket or SoW?
> > > >
> > > > --Yakov
> > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Anton Vinogradov-2
Folks,

How can it be at PATCH AVAILABLE since *none* of my latest comments (made
Feb 8) are resolved at Upsource?
Changed state to IP.

пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov <[hidden email]>:

> Hi Andrey,
>
> Could you please pick up review?
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <[hidden email]>:
>
> > Dmitriy, who is a good candidate within the community to review this
> > ticket?
> >
> > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <[hidden email]>
> > wrote:
> >
> > > Hi Igniters,
> > >
> > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is
> > still
> > > in PA state. What are our next steps?
> > >
> > > Who did review of this patch?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:
> > >
> > > > Yakov,
> > > >
> > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > >
> > > > Alex K., please follow to some thoughts from there and wrap them up
> in
> > a
> > > > form of the ticket.
> > > >
> > > > —
> > > > Denis
> > > >
> > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <[hidden email]>
> > > wrote:
> > > > >
> > > > > Guys, I remember we discussed this some time ago.
> > > > >
> > > > >
> > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > >
> > > > > Denis, do you have any ticket or SoW?
> > > > >
> > > > > --Yakov
> > > >
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Dmitriy Pavlov
Hi Anton,

Thank you for joining and review.
I hope all proposals will be applied.

Sincerely,
Dmitriy Pavlov

пт, 4 мая 2018 г. в 16:04, Anton Vinogradov <[hidden email]>:

> Folks,
>
> How can it be at PATCH AVAILABLE since *none* of my latest comments (made
> Feb 8) are resolved at Upsource?
> Changed state to IP.
>
> пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov <[hidden email]>:
>
> > Hi Andrey,
> >
> > Could you please pick up review?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <[hidden email]>:
> >
> > > Dmitriy, who is a good candidate within the community to review this
> > > ticket?
> > >
> > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <[hidden email]>
> > > wrote:
> > >
> > > > Hi Igniters,
> > > >
> > > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is
> > > still
> > > > in PA state. What are our next steps?
> > > >
> > > > Who did review of this patch?
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:
> > > >
> > > > > Yakov,
> > > > >
> > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > >
> > > > > Alex K., please follow to some thoughts from there and wrap them up
> > in
> > > a
> > > > > form of the ticket.
> > > > >
> > > > > —
> > > > > Denis
> > > > >
> > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <[hidden email]>
> > > > wrote:
> > > > > >
> > > > > > Guys, I remember we discussed this some time ago.
> > > > > >
> > > > > >
> > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > >
> > > > > > Denis, do you have any ticket or SoW?
> > > > > >
> > > > > > --Yakov
> > > > >
> > > > >
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Sergey Kosarev
HI, Igniters!

I've updated and rebased implementation to master branch and made some
fixes.
Also I have a question regarding current implementation.

As I found Cron4J source code this implementation checks schedule every
minute (seconds not supported) but spawns a thread for every task which
scheduling pattern matches the current time. There no any limits to the
number of tasks launched silmultaneously.

 New implementation is based on
org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
with its default parameters currently, i.e thread pool size is 1.

Could you advise me, do we need to add some system property or introduce
some attribute to IgniteConfiguration to configure Scheduler thread pool
size? And what should be default value?


Best regards,
Sergey Kosarev.


чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov <[hidden email]>:

> Hi Anton,
>
> Thank you for joining and review.
> I hope all proposals will be applied.
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 4 мая 2018 г. в 16:04, Anton Vinogradov <[hidden email]>:
>
> > Folks,
> >
> > How can it be at PATCH AVAILABLE since *none* of my latest comments (made
> > Feb 8) are resolved at Upsource?
> > Changed state to IP.
> >
> > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov <[hidden email]>:
> >
> > > Hi Andrey,
> > >
> > > Could you please pick up review?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <[hidden email]
> >:
> > >
> > > > Dmitriy, who is a good candidate within the community to review this
> > > > ticket?
> > > >
> > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <
> [hidden email]>
> > > > wrote:
> > > >
> > > > > Hi Igniters,
> > > > >
> > > > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565
> is
> > > > still
> > > > > in PA state. What are our next steps?
> > > > >
> > > > > Who did review of this patch?
> > > > >
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > >
> > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:
> > > > >
> > > > > > Yakov,
> > > > > >
> > > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > > >
> > > > > > Alex K., please follow to some thoughts from there and wrap them
> up
> > > in
> > > > a
> > > > > > form of the ticket.
> > > > > >
> > > > > > —
> > > > > > Denis
> > > > > >
> > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <
> [hidden email]>
> > > > > wrote:
> > > > > > >
> > > > > > > Guys, I remember we discussed this some time ago.
> > > > > > >
> > > > > > >
> > > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > > >
> > > > > > > Denis, do you have any ticket or SoW?
> > > > > > >
> > > > > > > --Yakov
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Replace Cron4J with Quartz for ignite-schedule module.

Alexey Kuznetsov
Hi, Sergey!

I think we should keep compatibility as much as possible for Ignite 2.x.
And we can do breaking changes in Ignite 3.x

What do you think?


On Mon, Dec 24, 2018 at 11:58 PM Sergey <[hidden email]> wrote:

> HI, Igniters!
>
> I've updated and rebased implementation to master branch and made some
> fixes.
> Also I have a question regarding current implementation.
>
> As I found Cron4J source code this implementation checks schedule every
> minute (seconds not supported) but spawns a thread for every task which
> scheduling pattern matches the current time. There no any limits to the
> number of tasks launched silmultaneously.
>
>  New implementation is based on
> org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
> with its default parameters currently, i.e thread pool size is 1.
>
> Could you advise me, do we need to add some system property or introduce
> some attribute to IgniteConfiguration to configure Scheduler thread pool
> size? And what should be default value?
>
>
> Best regards,
> Sergey Kosarev.
>
>
> чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov <[hidden email]>:
>
> > Hi Anton,
> >
> > Thank you for joining and review.
> > I hope all proposals will be applied.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пт, 4 мая 2018 г. в 16:04, Anton Vinogradov <[hidden email]>:
> >
> > > Folks,
> > >
> > > How can it be at PATCH AVAILABLE since *none* of my latest comments
> (made
> > > Feb 8) are resolved at Upsource?
> > > Changed state to IP.
> > >
> > > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov <[hidden email]>:
> > >
> > > > Hi Andrey,
> > > >
> > > > Could you please pick up review?
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <
> [hidden email]
> > >:
> > > >
> > > > > Dmitriy, who is a good candidate within the community to review
> this
> > > > > ticket?
> > > > >
> > > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <
> > [hidden email]>
> > > > > wrote:
> > > > >
> > > > > > Hi Igniters,
> > > > > >
> > > > > > it seems ticket
> https://issues.apache.org/jira/browse/IGNITE-5565
> > is
> > > > > still
> > > > > > in PA state. What are our next steps?
> > > > > >
> > > > > > Who did review of this patch?
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda <[hidden email]>:
> > > > > >
> > > > > > > Yakov,
> > > > > > >
> > > > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > > > >
> > > > > > > Alex K., please follow to some thoughts from there and wrap
> them
> > up
> > > > in
> > > > > a
> > > > > > > form of the ticket.
> > > > > > >
> > > > > > > —
> > > > > > > Denis
> > > > > > >
> > > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <
> > [hidden email]>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > Guys, I remember we discussed this some time ago.
> > > > > > > >
> > > > > > > >
> > > > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > > > >
> > > > > > > > Denis, do you have any ticket or SoW?
> > > > > > > >
> > > > > > > > --Yakov
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>


--
Alexey Kuznetsov
12